-
Notifications
You must be signed in to change notification settings - Fork 881
feat: add API/SDK support for autostop extension #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what will be the behavior when the user changes the TTL on a running workspace? Will you add functionality to the CLI so we also update the TTL to be closer to the new TTL?
Good idea! EDIT: Opened separate issue as this has a lot of if's and but's #1783 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments
ded669b
to
03ec987
Compare
* Adds deadline column to workspace_builds, associated DB/API plumbing * database: Upon inserting a row into workspace_builds, deadline will initially be zero. * autobuild: Executor now checks the Deadline field of the workspace_build for the purpose of autostop logic. * coderd: Adds a new route /api/v2/workspaces/:workspace/extend which allows updating the deadline of the currently active workspace build. The new deadline must be after the existing deadline, and not the zero time. * provisionerd: updates workspace_build.deadline upon successful workspace build completion (equal to now plus workspace TTL, if it exists).
deadline
column toworkspace_builds
, associated DB/API plumbingdatabase
: Upon inserting a row intoworkspace_builds
, deadline will be initially be zero.autobuild
:Executor
will now check theDeadline
field of the workspace_build for the purpose of autostop logic.coderd
: Adds a new route/api/v2/workspaces/:workspace/extend
which will allow updating the deadline of the currently active workspace build. The new deadline must be after the existing deadline, and not the zero time.provisionerd
: update workspace_build.deadline upon successful workspace build completion (equal to now plus workspace TTL, if it exists)Closes #1462