refactor: replace badge by status indicator - #17811
Merged
Merged
Conversation
BrunoQuaresma
requested review from
a team,
Kira-Pilot and
aslilac
and removed request for
a team and
Kira-Pilot
May 13, 2025 22:26
mtojek
approved these changes
May 14, 2025
| gap: 8, | ||
| }} | ||
| > | ||
| <div className="flex items-center gap-4"> |
Member
There was a problem hiding this comment.
curious: why is it better than css property?
Contributor
Author
There was a problem hiding this comment.
Because we are moving away from MUI and emotion to use shadcn and TailwindCSS. So we want to be consistent and only use the new stack.
Member
There was a problem hiding this comment.
Thanks for the explanation, TIL!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
In the workspaces page, it is using the status indicator, and not the badge anymore, so to keep the UI consistent, I'm replacing the badge by the indicator in the workspace page too.
Before:
After:
