Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(agent): send devcontainer CLI logs during recreate #17845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 15, 2025
Merged

feat(agent): send devcontainer CLI logs during recreate #17845

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
f144a03
feat(agent): send devcontainer CLI logs to coderd during recreate
mafredri May 14, 2025
5a74d6f
fix typo
mafredri May 15, 2025
7d9d161
testutil.Eventually
mafredri May 15, 2025
abdd813
log
mafredri May 15, 2025
4c71a6c
fix test
mafredri May 15, 2025
d9cd988
fix lint
mafredri May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix lint
  • Loading branch information
@mafredri
mafredri committed May 15, 2025
commit d9cd9889c62bc1a713dda6ec7a02d44b247e844f
1 change: 1 addition & 0 deletions agent/agent_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2135,6 +2135,7 @@ func TestAgent_DevcontainerRecreate(t *testing.T) {
if os.Getenv("CODER_TEST_USE_DOCKER") != "1" {
t.Skip("Set CODER_TEST_USE_DOCKER=1 to run this test")
}
t.Parallel()

pool, err := dockertest.NewPool("")
require.NoError(t, err, "Could not connect to docker")
Expand Down
6 changes: 3 additions & 3 deletions agent/agentcontainers/api.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,15 +137,15 @@ func WithWatcher(w watcher.Watcher) Option {
// controlplane.
type ScriptLogger interface {
Send(ctx context.Context, log ...agentsdk.Log) error
Flush(context.Context) error
Flush(ctx context.Context) error
}

// noopScriptLogger is a no-op implementation of the ScriptLogger
// interface.
type noopScriptLogger struct{}

func (noopScriptLogger) Send(ctx context.Context, log ...agentsdk.Log) error { return nil }
func (noopScriptLogger) Flush(ctx context.Context) error { return nil }
func (noopScriptLogger) Send(context.Context, ...agentsdk.Log) error { return nil }
func (noopScriptLogger) Flush(context.Context) error { return nil }

// WithScriptLogger sets the script logger provider for devcontainer operations.
func WithScriptLogger(scriptLogger func(logSourceID uuid.UUID) ScriptLogger) Option {
Expand Down
Loading