chore: reduce ignore_changes suggestion scope
#17947
Conversation
Signed-off-by: Danny Kopping <[email protected]>
|
Thanks for doing this! It was on my to-do list but appreciate you beating me to it. |
There was a problem hiding this comment.
Oops, before we merge lets also call this out in this place too: https://coder.com/docs/admin/templates/extending-templates/resource-persistence#-bulletproofing
docs/admin/templates/extending-templates/prebuilt-workspaces.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Edward Angert <[email protected]>
We currently don't show which fields caused drift for non-prebuild builds. #17571 introduced the drift output, but restricts it to only show when prebuild claims are taking place. We discussed holding off on showing that all the time because some customers may not want this information displayed. Sensitive values are stripped out, however. In any case, without this info of which attributes caused drift we can't advise operators/admins to be more specific with |
We probably shouldn't be suggesting
ignore_changes = all. Only the attributes which cause drift in prebuilds should be ignored; everything else can behave as normal.