feat: create experimental template embed page for dynamic params #17999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7c28011 to
71d0a19
Compare
97fe2be to
e9671b9
Compare
aslilac
approved these changes
Jun 23, 2025
There was a problem hiding this comment.
@BrunoQuaresma might have more context/thoughts on this page than me if you have time to get a review from him, but it all looks reasonable to me
| if (parameters) { | ||
| const serverParamValues: Record<string, string> = {}; | ||
| for (const p of parameters) { | ||
| const initialVal = p.value?.valid ? p.value.value : ""; |
There was a problem hiding this comment.
Suggested change
| const initialVal = p.value?.valid ? p.value.value : ""; | |
| const initialVal = p.value?.valid ?? ""; |
more question marks in exchange for being slightly terser 🤷♀️
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves coder/preview#58