Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: autofill with workspace build parameters from the latest build #18091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 29, 2025
Merged

fix: autofill with workspace build parameters from the latest build #18091

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
53a5754
chore: autofill previous values from build on workspace settings
Emyrk May 28, 2025
2962196
add initialTouched
Emyrk May 28, 2025
9e67844
fix: set initial autofill parameters from latest workspace build para…
jaaydenh May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: autofill previous values from build on workspace settings
  • Loading branch information
@Emyrk
Emyrk committed May 28, 2025
commit 53a57543dd116ccc81e93f1c786332ef9228f6a6
7 changes: 7 additions & 0 deletions ...ges/WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,11 @@ const WorkspaceParametersPageExperimental: FC = () => {
const navigate = useNavigate();
const experimentalFormContext = useContext(ExperimentalFormContext);

const { data: originalParameters, isLoading: originalParametersLoading } = useQuery({
queryKey: ["workspace", "build", workspace.id, "parameters"],
queryFn: () => API.getWorkspaceBuildParameters(workspace.latest_build.id),
});

const [latestResponse, setLatestResponse] =
useState<DynamicParametersResponse | null>(null);
const wsResponseId = useRef<number>(-1);
Expand Down Expand Up @@ -149,6 +154,7 @@ const WorkspaceParametersPageExperimental: FC = () => {
const error = wsError || updateParameters.error;

if (
originalParametersLoading ||
!latestResponse ||
(ws.current && ws.current.readyState === WebSocket.CONNECTING)
) {
Expand Down Expand Up @@ -203,6 +209,7 @@ const WorkspaceParametersPageExperimental: FC = () => {
<WorkspaceParametersPageViewExperimental
workspace={workspace}
canChangeVersions={canChangeVersions}
originalParameters={originalParameters!}
parameters={sortedParams}
diagnostics={latestResponse.diagnostics}
isSubmitting={updateParameters.isPending}
Expand Down
7 changes: 6 additions & 1 deletion ...WorkspaceSettingsPage/WorkspaceParametersPage/WorkspaceParametersPageViewExperimental.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import { docs } from "utils/docs";

type WorkspaceParametersPageViewExperimentalProps = {
workspace: Workspace;
originalParameters?: WorkspaceBuildParameter[];
parameters: PreviewParameter[];
diagnostics: PreviewParameter["diagnostics"];
canChangeVersions: boolean;
Expand All @@ -34,6 +35,7 @@ export const WorkspaceParametersPageViewExperimental: FC<
WorkspaceParametersPageViewExperimentalProps
> = ({
workspace,
originalParameters,
parameters,
diagnostics,
canChangeVersions,
Expand All @@ -45,7 +47,10 @@ export const WorkspaceParametersPageViewExperimental: FC<
const form = useFormik({
onSubmit,
initialValues: {
rich_parameter_values: getInitialParameterValues(parameters),
rich_parameter_values: getInitialParameterValues(parameters, originalParameters!.map((p) => ({
...p,
source: "active_build",
}))),
},
validationSchema: useValidationSchemaForDynamicParameters(parameters),
enableReinitialize: false,
Expand Down