docs: update deployments experiments for June 3 release #18196
+60
−136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stirby
approved these changes
Jun 3, 2025
|
@stirby - looks like it's failing because it's not as straightforward as just removing it from |
- Remove ExperimentWorkspaceUsage, ExperimentNotifications, and ExperimentWebPush - Enable workspace usage tracking by default in telemetry and metrics - Enable web push notifications by default - Update all references throughout codebase including tests - Remove experiment checks that were causing compilation errors Co-authored-by: EdwardAngert <[email protected]>
Co-authored-by: EdwardAngert <[email protected]>
- Remove web-push experiment check from useWebpushNotifications - Remove notifications experiment from storybook configurations - Enable web push and notifications by default in frontend Co-authored-by: EdwardAngert <[email protected]>
…fect The enabledExperimentsQuery.data dependency was not used within the useEffect hook and was causing a linting error. The effect only sets enabled state, checks browser support, and verifies subscription status. Co-authored-by: EdwardAngert <[email protected]>
The test was experiencing a data race where the collected map was being modified in the assert.Eventuallyf goroutine while being read by cmp.Diff. Fixed by creating a local map in each iteration and only assigning it to the shared variable when the comparison succeeds, eliminating concurrent access to the same map. Co-authored-by: EdwardAngert <[email protected]>
matifali
requested changes
Jun 21, 2025
Comment on lines
+60
to
+64
| // Session stats are now handled by the CLI and the postWorkspaceUsage route. | ||
| req.Stats.SessionCountSsh = 0 | ||
| req.Stats.SessionCountJetbrains = 0 | ||
| req.Stats.SessionCountVscode = 0 | ||
| req.Stats.SessionCountReconnectingPty = 0 |
There was a problem hiding this comment.
These changes look unrelated.
We are not graduating the workspace-usage experiment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18083