chore: route connection logs to new table #18340
Draft
+2,012
−456
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Requesting a draft review just to confirm we're happy with the DB schema, the RBAC setup, and the overall direction. |
ethanndickson
commented
Jun 12, 2025
ethanndickson
commented
Jun 12, 2025
Emyrk
reviewed
Jun 12, 2025
mafredri
reviewed
Jun 15, 2025
| return nil | ||
| } | ||
|
|
||
| func NewMock() *MockConnectionLogger { |
There was a problem hiding this comment.
Suggestion: This feels more like a "fake" than a "mock".
| connection_logs | ||
| LEFT JOIN users ON | ||
| connection_logs.user_id = users.id | ||
| LEFT JOIN users as workspace_owner ON |
There was a problem hiding this comment.
Suggested change
| LEFT JOIN users as workspace_owner ON | |
| LEFT JOIN users AS workspace_owner ON |
| -- limit of 100 to prevent accidental excessively large queries. | ||
| COALESCE(NULLIF(@limit_opt :: int, 0), 100) | ||
| OFFSET | ||
| @offset_opt; |
There was a problem hiding this comment.
Note: Using limit/offset will get increasingly more slow as the table grows and you paginate further. First page will usually remain fast though.
Fine for now, though. Just raising awareness.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR of a few for moving connection events out of the audit log, and into a new database table and web UI page called the 'Connection Log'.
This PR:
ConnectionLoggerabstraction to replace theAuditorabstraction for these logs. (No-op'd in AGPL, like theAuditor)ConnectionLoggerConnectionLoggerinstead of theAuditor.Future PRs:
dbpurge.Note
The PRs in this stack obviously won't be (completely) atomic. Whilst they'll each pass CI, the stack is designed to be merged all at once. I'm splitting them up for the sake of those reviewing, and so changes can be reviewed as early as possible. Despite this, it's really hard to make this PR any smaller than it already is. I'll be keeping it in draft until it's actually ready to merge.