feat: allow for default presets #18445

dannykopping · 2025-06-19T08:16:42Z

Disclaimer: mostly implemented by Claude Code.

Depends on: coder/terraform-provider-coder#414
Closes: #18110

I've tested this against both the classic and new (dynamic parameters) approaches.

...
data "coder_workspace_preset" "goland" {
  default = true													# <-----------------
  name = "I Like GoLand"
  parameters = {
    "jetbrains_ide" = "GO"
    "cpu"           = "2"
  }
}

data "coder_workspace_preset" "python" {
  name = "Some Like PyCharm"
  parameters = {
    "jetbrains_ide" = "PY"
  }
}
...

Default preset is autoselected on load:

Signed-off-by: Danny Kopping <[email protected]>

dannykopping · 2025-06-19T08:18:03Z

CLAUDE.md

@@ -103,5 +103,4 @@ Read [cursor rules](.cursorrules).

 The frontend is contained in the site folder.

-For building Frontend refer to [this document](docs/contributing/frontend.md)


Drive-by: link is dead.

~~it's in docs/about/contributing/ now. can you leave this as is and I'll do a quick pr to fix the link?~~

sorry, I just looked at the whole file and this diff makes more sense now. the line got duplicated, with one having the out of date path and one having the correct path. you're just removing the stale one.

dannykopping · 2025-06-19T08:20:04Z

go.mod

@@ -72,6 +72,9 @@ replace github.com/aquasecurity/trivy => github.com/coder/trivy v0.0.0-202505271
 // https://github.com/spf13/afero/pull/487
 replace github.com/spf13/afero => github.com/aslilac/afero v0.0.0-20250403163713-f06e86036696

+// TODO: replace once we cut release.


TODO: depends on coder/terraform-provider-coder#414.

Might make sense to wait until that is merged + tagged first?

provisionersdk/proto/provisioner.proto

Signed-off-by: Danny Kopping <[email protected]>

johnstcn

Changes look OK to me, with the provisio that we should merge + pre-release the provider change first

johnstcn · 2025-06-19T09:12:24Z

provisioner/terraform/resources_test.go

+	}
+
+	for name, tc := range cases {
+		tc := tc


Suggested change

tc := tc

johnstcn · 2025-06-19T09:14:58Z

provisioner/terraform/resources_test.go

+	t.Parallel()
+
+	// nolint:dogsled
+	_, filename, _, _ := runtime.Caller(0)


nit, non-blocking: I understand that this is copied from other tests, but I wonder if we could use t.Name() instead?

johnstcn · 2025-06-19T09:16:10Z

go.mod

@@ -72,6 +72,9 @@ replace github.com/aquasecurity/trivy => github.com/coder/trivy v0.0.0-202505271
 // https://github.com/spf13/afero/pull/487
 replace github.com/spf13/afero => github.com/aslilac/afero v0.0.0-20250403163713-f06e86036696

+// TODO: replace once we cut release.


Might make sense to wait until that is merged + tagged first?

johnstcn · 2025-06-19T09:18:30Z

coderd/database/migrations/000338_template_version_preset_default.up.sql

Obligatory reminder to check migration number before merge

Signed-off-by: Danny Kopping <[email protected]>

SasSwart · 2025-06-19T13:17:47Z

site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx

+		if (defaultPreset) {
+			// +1 because "None" is at index 0
+			const defaultIndex =
+				presets.findIndex((preset) => preset.ID === defaultPreset.ID) + 1;


It looks like this fine, but I've been caught by findIndex before while working on presets. Is there any way that findIndex might return -1 here?

site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx

Replace findIndex with find() to avoid -1 edge case and consolidate preset initialization into single useEffect for better maintainability. Signed-off-by: Danny Kopping <[email protected]>

aslilac · 2025-06-23T20:58:25Z

site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx

+		setPresetOptions(options);
+		const defaultPreset = presets.find((p) => p.Default);
+		if (defaultPreset) {
+			const idx = presets.indexOf(defaultPreset) + 1; // +1 for "None"


this is really confusing. so 0 is "none", but we want to special case it to 1, which should be the default if defaultPreset is true? is the first "real" option actually guaranteed to be the default? if so, why are we searching the array for it?

None is index 0, indexOf can return -1.

site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx

aslilac · 2025-06-23T21:01:16Z

site/src/pages/CreateWorkspacePage/CreateWorkspacePageViewExperimental.tsx

+		if (defaultPreset) {
+			// +1 because "None" is at index 0
+			const defaultIndex =
+				presets.findIndex((preset) => preset.ID === defaultPreset.ID) + 1;


...or I guess it's because everything is this presets array ends up getting offset by one for having "none" at the beginning? that feels really weird, it'd make a lot more sense to me if the numbers were preserved and "none" was represented by null or something

Agreed; I think we need a wider refactor of the implementation. For now though, I'm going to have to use what's present. @SasSwart WDYT?

Coping with the none preset in the FE has felt weird from the start. I'm considering the idea that "None" should be a preset returned like any other from the endpoint that lists presets. it would simplify the FE quite a bit and centralize how me manage it.

Signed-off-by: Danny Kopping <[email protected]>

dannykopping added 4 commits June 18, 2025 16:35

chore: database changes

89da41b

Signed-off-by: Danny Kopping <[email protected]>

chore: proto changes

7e75433

Signed-off-by: Danny Kopping <[email protected]>

chore: use new provider, accept values for default

0fb3743

Signed-off-by: Danny Kopping <[email protected]>

feat: full implementation

e9a218c

Signed-off-by: Danny Kopping <[email protected]>

github-actions bot assigned dannykopping Jun 19, 2025

dannykopping changed the title ~~feat: default presets~~ feat: allow for default presets Jun 19, 2025

chore: improve version constraints

a6e4d0a

Signed-off-by: Danny Kopping <[email protected]>

dannykopping commented Jun 19, 2025

View reviewed changes

dannykopping requested review from SasSwart and BrunoQuaresma June 19, 2025 08:27

dannykopping marked this pull request as ready for review June 19, 2025 08:27

dannykopping requested review from spikecurtis and johnstcn as code owners June 19, 2025 08:27

johnstcn reviewed Jun 19, 2025

View reviewed changes

provisionersdk/proto/provisioner.proto Outdated Show resolved Hide resolved

chore: update provisioner version comment

1b737ff

Signed-off-by: Danny Kopping <[email protected]>

johnstcn approved these changes Jun 19, 2025

View reviewed changes

chore: generate test fixtures correctly

f0f77fb

Signed-off-by: Danny Kopping <[email protected]>

SasSwart reviewed Jun 19, 2025

View reviewed changes

site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.stories.tsx Show resolved Hide resolved

dannykopping added 2 commits June 23, 2025 21:45

Merge branch 'main' of github.com:/coder/coder into dk/default-preset

83192a7

refactor: improve preset selection logic in workspace creation

0d9d751

Replace findIndex with find() to avoid -1 edge case and consolidate preset initialization into single useEffect for better maintainability. Signed-off-by: Danny Kopping <[email protected]>

aslilac reviewed Jun 23, 2025

View reviewed changes

dannykopping added 2 commits June 24, 2025 11:12

Merge branch 'main' of github.com:coder/coder into dk/default-preset

590eb4e

chore: fix up storybook tests

737e1c6

Signed-off-by: Danny Kopping <[email protected]>

dannykopping force-pushed the dk/default-preset branch from 9bb383a to 737e1c6 Compare June 24, 2025 09:24

dannykopping added 2 commits June 24, 2025 11:56

Merge branch 'main' of github.com:/coder/coder into dk/default-preset

ce92f1f

chore: ensure "None" value is set correctly

371ac5a

Signed-off-by: Danny Kopping <[email protected]>

dannykopping merged commit 6cc4cfa into main Jun 24, 2025
39 checks passed

dannykopping deleted the dk/default-preset branch June 24, 2025 10:19

github-actions bot locked and limited conversation to collaborators Jun 24, 2025

		@@ -103,5 +103,4 @@ Read [cursor rules](.cursorrules).

		The frontend is contained in the site folder.

		For building Frontend refer to [this document](docs/contributing/frontend.md)

feat: allow for default presets #18445

feat: allow for default presets #18445

Conversation

dannykopping commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aslilac Jun 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

johnstcn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dannykopping commented Jun 19, 2025 •

edited

Loading

aslilac Jun 23, 2025 •

edited

Loading