Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: use backend-supplied sidebar app id on the /task/$id page #18458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2025
Merged

feat: use backend-supplied sidebar app id on the /task/$id page #18458

merged 1 commit into from
Jun 24, 2025
+231 −156

Conversation

hugodutka
Copy link
Contributor

@hugodutka hugodutka commented Jun 19, 2025 •
edited
Loading

Related to #18454. It will close coder/internal#734.

DANGER: this must be merged only after the issues mentioned in the issue above are closed.

@hugodutka hugodutka changed the base branch from main to hugodutka/ai-tasks-codersdk-wb June 19, 2025 14:38
@hugodutka hugodutka force-pushed the hugodutka/task-page-use-new-backend branch from ed4e231 to e3c77d1 Compare June 19, 2025 14:46
@hugodutka hugodutka marked this pull request as ready for review June 19, 2025 14:53
@hugodutka hugodutka requested a review from BrunoQuaresma June 19, 2025 14:53
BrunoQuaresma
BrunoQuaresma approved these changes Jun 19, 2025
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I would change the commit name since it is not using the new backend routes tho. From what I can see, the only difference is, it is using a new prop to find the sidebar app.

site/src/modules/tasks/tasks.ts Outdated
@@ -4,5 +4,5 @@ export const AI_PROMPT_PARAMETER_NAME = "AI Prompt";

export type Task = {
workspace: Workspace;
prompt: string;
prompt?: string;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to have a task without a prompt?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it'd happen in practice. I'll change the type.

@hugodutka hugodutka changed the title feat: use the new backend routes on the /task/$id page feat: use backend-supplied sidebar app id on the /task/$id page Jun 19, 2025
@hugodutka hugodutka requested a review from code-asher June 19, 2025 17:05
@hugodutka hugodutka force-pushed the hugodutka/ai-tasks-codersdk-wb branch from 6a03c80 to 462415d Compare June 19, 2025 19:52
@hugodutka hugodutka force-pushed the hugodutka/task-page-use-new-backend branch 2 times, most recently from 7671863 to f338120 Compare June 19, 2025 20:26
@hugodutka hugodutka force-pushed the hugodutka/ai-tasks-codersdk-wb branch from 462415d to 5b7cae3 Compare June 19, 2025 20:26
@hugodutka hugodutka force-pushed the hugodutka/task-page-use-new-backend branch from f338120 to e44a653 Compare June 19, 2025 20:49
Base automatically changed from hugodutka/ai-tasks-codersdk-wb to main June 20, 2025 08:59
@hugodutka hugodutka force-pushed the hugodutka/task-page-use-new-backend branch 3 times, most recently from b96d72d to d8ad0ed Compare June 24, 2025 15:09
@hugodutka hugodutka force-pushed the hugodutka/task-page-use-new-backend branch from d8ad0ed to 21489b0 Compare June 24, 2025 16:30
@hugodutka hugodutka merged commit 4fd0312 into main Jun 24, 2025
31 of 33 checks passed
@hugodutka hugodutka deleted the hugodutka/task-page-use-new-backend branch June 24, 2025 17:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

@code-asher code-asher Awaiting requested review from code-asher

Assignees

@hugodutka hugodutka

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tasks: remove task status list from the /task/$id page sidebar
2 participants
@hugodutka @BrunoQuaresma