fix(agent/agentcontainers): read WorkspaceFolder from config #18467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of exec'ing `pwd` inside of the container, we instead read `WorkspaceFolder` from the outcome of `read-configuration`.
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the execution of "pwd" inside containers with reading the workspace folder from the container configuration, thereby aligning the implementation with the new configuration-based approach.
- Introduces a new Workspace field (of type DevcontainerWorkspace) in the devcontainer configuration.
- Updates tests to expect the workspace folder from configuration and adjusts label paths accordingly.
- Removes legacy exec-based workspace folder detection from the API logic.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| agent/agentcontainers/devcontainercli.go | Adds the Workspace field and its corresponding type to support configuration-based workspace retrieval. |
| agent/agentcontainers/api_test.go | Updates test expectations by removing assertions on exec-based "pwd" detection and adjusting folder labels. |
| agent/agentcontainers/api.go | Removes exec-based folder detection and assigns the workspace folder from configuration. |
Comments suppressed due to low confidence (2)
agent/agentcontainers/api.go:1150
- Consider adding tests for cases where config.Workspace.WorkspaceFolder might be empty to ensure that the default workspace folder is used as a fallback.
workspaceFolder = config.Workspace.WorkspaceFolder
agent/agentcontainers/api_test.go:1328
- Verify that the removal of exec-based checks does not leave any gaps in test coverage for the workspace folder initialization; additional tests may be required to cover this new configuration flow.
testutil.RequireSend(ctx, t, fakeDCCLI.readConfigErrC, func(envs []string) error {
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of exec'ing
pwdinside of the container, we instead readWorkspaceFolderfrom the outcome ofread-configuration.