feat: implement efficient backend querying on the tasks page #18488
+159
−167
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3883a22 to
c4d88d5
Compare
c4d88d5 to
4f403dd
Compare
4b753a6 to
f62da9d
Compare
4f403dd to
69a2e2d
Compare
f62da9d to
f114f43
Compare
69a2e2d to
97a00ba
Compare
f114f43 to
bf23151
Compare
97a00ba to
604f994
Compare
code-asher
approved these changes
Jun 23, 2025
| @@ -211,7 +247,7 @@ const TaskForm: FC<TaskFormProps> = ({ templates }) => { | |||
| form.reset(); | |||
| } catch (error) { | |||
| const message = getErrorMessage(error, "Error creating task"); | |||
| const detail = getErrorDetail(error) ?? "Please, try again"; | |||
| const detail = getErrorDetail(error) ?? "Please try again"; | |||
There was a problem hiding this comment.
Extremely minor, just noticing that this error message has no comma but the ones on 174 and 379 do. Personally I like it better without a comma.
| /> | ||
| ); | ||
| } | ||
| if (templates == null) { |
There was a problem hiding this comment.
Also minor: I think the linter is fine with this, but everywhere else we do === null (triple equals) or just if (templates).
1273e3c to
5a42c7e
Compare
604f994 to
b791c0a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
/workspaces?q=has-ai-task=true,/templates?q=has-ai-task=trueand/aitasks/promptsendpoints to fetch Task templates and workspaces on the/taskspage.Also:
Related to #18454 and coder/internal#660.
DANGER: this PR must be merged only after all issues mentioned in #18454 are closed to avoid breaking the dogfood environment.