fix: fix validation error during workspace creation without preset #18494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
approved these changes
Jun 23, 2025
ssncferreira
approved these changes
Jun 23, 2025
| action("onSubmit")(request, owner); | ||
| }, | ||
| }, | ||
| play: async ({ canvasElement }) => { |
mafredri
approved these changes
Jun 23, 2025
|
|
||
| // Then select "None" to unset the field value | ||
| await userEvent.click(canvas.getByLabelText("Preset")); | ||
| await userEvent.click(canvas.getByText("None")); |
There was a problem hiding this comment.
Is this potentially too vague? Perhaps not now as we control the test but considering future changes.
use option?.value instead of index to check whether we should send a preset ID when a workspace is created Co-authored-by: Susana Ferreira <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #18430.
Selecting a preset, and then selecting the "None" preset used to set the preset ID to an empty string instead of
undefined. This sent""to the backend, which expects a valid UUID.