Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: update workspace table icons in WorkspacesTable #18525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 24, 2025

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Jun 24, 2025

Updates icons in WorkspacesTable to better differentiate between "start" and "update and start".

Note: the logic I'm currently using is as follows:

  • Workspace does not require active version and is outdated -> cloud icon
  • Workspace requires active version and is outdated -> circle play icon

I also, on a whim, updated the stories for the component to make the workspace names more identifiably reflect their content.

Screenshot 2025-06-24 at 11 49 17

Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Perhaps a reviewer with artistic skills could also review this concept.

Copy link
Contributor

@dannykopping dannykopping left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johnstcn johnstcn force-pushed the cj/ui-workspace-table-update-icon branch from a67f5ed to 6f902e0 Compare June 24, 2025 16:53
@johnstcn johnstcn requested a review from BrunoQuaresma June 24, 2025 17:55
@johnstcn johnstcn merged commit 7070e47 into main Jun 24, 2025
33 checks passed
@johnstcn johnstcn deleted the cj/ui-workspace-table-update-icon branch June 24, 2025 18:24
@github-actions github-actions bot locked and limited conversation to collaborators Jun 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants