fix(coderd/agentapi): make sub agent slugs more unique #18581
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The incorrect assumption that slugs were unique per-agent was made when the subagent API was implemented. Whilst this PR doesn't completely enforce that, we instead compute a stable hash to prefix the slug that should provide a reasonable level of probability that the slug will be unique.
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the incorrect assumption of unique subagent slugs per agent by prefixing each slug with a stable CRC32 hash computed from the subagent name and original slug.
- Updated test expectations in subagent_test.go to check for the new hash-prefixed slug format.
- Modified the slug generation in subagent.go to compute and append a CRC32 hash to the original slug.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| coderd/agentapi/subagent_test.go | Updated test cases to expect new hash-prefixed slugs. |
| coderd/agentapi/subagent.go | Added CRC32-based hash computation to generate unique slugs. |
mafredri
approved these changes
Jun 25, 2025
coderd/agentapi/subagent.go
Outdated
| // there is no database-layer enforcement of this constraint. | ||
| // We can get around this by creating a slug that *should* be | ||
| // unique (at least highly probable). | ||
| slugHash := fmt.Sprintf("%08x", crc32.ChecksumIEEE([]byte(subAgent.Name+"/"+app.Slug))) |
There was a problem hiding this comment.
I wonder if we should use crypto/sha256 or hash/fnv instead? Crc32 isn’t particularly good for collision prevention.
There was a problem hiding this comment.
Sounds good! I've made the change in 3e9f2f3.
Now we use a sha256 hash, encode it with base32 encoding, truncate it to 8 characters, then lower case it.
mafredri
approved these changes
Jun 25, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The incorrect assumption that slugs were unique per-agent was made when the subagent API was implemented. Whilst this PR doesn't completely enforce that, we instead compute a stable hash to prefix the slug that should provide a reasonable level of probability that the slug will be unique.