feat: test parameter immutability validation #18583
Draft
+74
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emyrk
commented
Jun 25, 2025
Comment on lines
+355
to
+388
| t.Run("ImmutableChangeValue", func(t *testing.T) { | ||
| // Ok this is a weird test to document how things are working. | ||
| // What if a parameter flips it's immutability based on a value? | ||
| // The current behavior is to source immutability from the previous build. | ||
| t.Parallel() | ||
|
|
||
| ctx := testutil.Context(t, testutil.WaitShort) | ||
| // Start with a new template that has 1 parameter that is immutable | ||
| immutable, _ := coderdtest.DynamicParameterTemplate(t, templateAdmin, orgID, coderdtest.DynamicParameterTemplateParams{ | ||
| MainTF: string(must(os.ReadFile("testdata/parameters/dynamicimmutable/main.tf"))), | ||
| }) | ||
|
|
||
| // Create the workspace with the immutable parameter | ||
| wrk, err := templateAdmin.CreateUserWorkspace(ctx, codersdk.Me, codersdk.CreateWorkspaceRequest{ | ||
| TemplateID: immutable.ID, | ||
| Name: coderdtest.RandomUsername(t), | ||
| RichParameterValues: []codersdk.WorkspaceBuildParameter{ | ||
| {Name: "isimmutable", Value: "true"}, | ||
| {Name: "immutable", Value: "coder"}, | ||
| }, | ||
| }) | ||
| require.NoError(t, err) | ||
| coderdtest.AwaitWorkspaceBuildJobCompleted(t, templateAdmin, wrk.LatestBuild.ID) | ||
|
|
||
| // Try new values | ||
| _, err = templateAdmin.CreateWorkspaceBuild(ctx, wrk.ID, codersdk.CreateWorkspaceBuildRequest{ | ||
| Transition: codersdk.WorkspaceTransitionStart, | ||
| RichParameterValues: []codersdk.WorkspaceBuildParameter{ | ||
| {Name: "isimmutable", Value: "false"}, | ||
| {Name: "immutable", Value: "not-coder"}, | ||
| }, | ||
| }) | ||
| require.ErrorContains(t, err, `Previously immutable parameter changed`) | ||
| }) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What should happen in this situation. A template where the parameter
isimmutablesets the mutability ofimmutable.Terraform:
Trivial Case:
isimmutable = true&immutable = "bar"immutable = fooImmutability source from the past
isimmutable = true&immutable = "bar"immutable = foo&isimmutable = falseEither it:
isimmutableWAS immutable on the previous buildisimmutableis nowmutablefrom the new param