chore(coderd/database): optimize GetRunningPrebuiltWorkspaces #18588
Conversation
| ready_agents.job_id = latest_prebuilds.job_id | ||
| ORDER BY | ||
| latest_prebuilds.workspace_id ASC | ||
| ; |
| latest_prebuilds | ||
| AS ( |
There was a problem hiding this comment.
| latest_prebuilds | |
| AS ( | |
| latest_prebuilds AS ( |
We could reduce indentation a bit here.
| FROM | ||
| workspaces | ||
| LEFT JOIN LATERAL ( |
There was a problem hiding this comment.
| FROM | |
| workspaces | |
| LEFT JOIN LATERAL ( | |
| FROM | |
| workspaces | |
| LEFT JOIN LATERAL ( |
As well as here, SQL is a weird syntax in that it doesn't really have any meaningful nesting.
| provisioner_jobs.id | ||
| = workspace_builds.job_id |
There was a problem hiding this comment.
| provisioner_jobs.id | |
| = workspace_builds.job_id | |
| provisioner_jobs.id = workspace_builds.job_id |
What's this 😆, (see others as well)
| AS ( | ||
| SELECT | ||
| latest_prebuilds.job_id, | ||
| BOOL_AND(workspace_agents.lifecycle_state = 'ready'::workspace_agent_lifecycle_state)::boolean AS ready |
There was a problem hiding this comment.
| BOOL_AND(workspace_agents.lifecycle_state = 'ready'::workspace_agent_lifecycle_state)::boolean AS ready | |
| workspace_agents.lifecycle_state = 'ready'::workspace_agent_lifecycle_state AS ready |
What's this, it actually works?
| latest_prebuilds.created_at | ||
| FROM | ||
| latest_prebuilds | ||
| LEFT JOIN ready_agents ON |
There was a problem hiding this comment.
This join will duplicate rows when there are multiple agents since there is no group-by here or in the ready_agents CTE, was this considered?
| JOIN workspace_agents ON | ||
| workspace_agents.resource_id = workspace_resources.id | ||
| WHERE | ||
| workspace_agents.deleted = false |
There was a problem hiding this comment.
For consideration: Should we filter out sub agents? I.e. AND workspace_agents.parent_id IS NULL.
| AND latest_build.transition | ||
| = 'start'::workspace_transition | ||
| AND latest_build.job_status | ||
| = 'succeeded'::provisioner_job_status |
There was a problem hiding this comment.
Potential performance improvement, move these into latest_build subquery.
Also, please consider whether it should be a LEFT JOIN LATERAL or (INNER) JOIN LATERAL. With these filters it's essentially an INNER join currently.
| workspace_builds.workspace_id | ||
| = workspaces.id | ||
| ORDER BY | ||
| workspace_builds.workspace_id, |
There was a problem hiding this comment.
Suggestion: Could remove this redundant ordering due to WHERE filter (keep build_number though).
Fixes coder/internal#715
Before: ~44ms https://explain.dalibo.com/plan/76cbe21d1a4c9329#plan
After: ~3.7ms https://explain.dalibo.com/plan/f61beg93f9306fc0#plan