chore: remove unnecessary redeclarations in for loops (part 2) #18593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslilac
commented
Jun 25, 2025
Comment on lines
-411
to
-413
| // When we assign the non-pointer to a | ||
| // variable it loses the reference. | ||
| replica := replica |
Member
Author
There was a problem hiding this comment.
@johnstcn you called out this one as potentially being a concern, but I think there are already two "copies" happening here that make this safe
- it gets copied from the slice to the
replicavariable by the loop - it gets copied from the
replicavariable to the argument value as part of theappendcall on the next line
ie. go does not have "references", it has pointers and values. you're either copying a pointer or you're copying the whole value.
here's a go playground that hopefully instills confidence https://go.dev/play/p/MfFltxQepYE
johnstcn
approved these changes
Jun 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we're post code-freeze, let's go forth with the other half of this cleanup.