chore(coderd/database): optimize AuditLogs queries #18600
+743
−239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dit logs query with conditional joins
ibetitsmike
reviewed
Jun 26, 2025
| workspace_builds.build_number = 1 | ||
| ) | ||
| LEFT JOIN organizations ON audit_logs.organization_id = organizations.id | ||
| SELECT sqlc.embed(audit_logs), |
There was a problem hiding this comment.
I'd a comment that CountAuditLogs also needs to be extended whenever we extend the filtering on GetAuditLogsOffset
There was a problem hiding this comment.
Or maybe better - add a test that compares the filter object for this method and count method
There was a problem hiding this comment.
I have added a new test which compares WHERE clause for both queries :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17689
This PR optimizes the audit logs query performance by extracting the count operation into a separate query and replacing the OR-based workspace_builds with conditional joins.
Query changes
workspace_buildsjoin with OR conditions with separate conditional joinswb_buildfor workspace_build audit logs (which is a direct lookup)wb_workspacefor workspace create audit logs (via workspace)Optimized AuditLogsOffset query:
https://explain.dalibo.com/plan/4g1hbedg4a564bg8
New CountAuditLogs query:
https://explain.dalibo.com/plan/ga2fbcecb9efbce3