Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(.devcontainer): install dotfiles if present #18606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 26, 2025
Merged

feat(.devcontainer): install dotfiles if present #18606

merged 2 commits into from
Jun 26, 2025
+67 −4

Conversation

mafredri
Copy link
Member

@mafredri mafredri commented Jun 26, 2025 •
edited
Loading

Not happy about mounting in the whole $HOME into the container (even if read-only), but it only exists as a proposal. See devcontainers/spec#132.

@mafredri mafredri changed the title feat(devcontainer): install dotfiles if present feat(.devcontainer): install dotfiles if present Jun 26, 2025
@mafredri mafredri force-pushed the mafredri/feat-devcontainer-install-dotfiles branch from 21326b3 to 5b06170 Compare June 26, 2025 12:18
@mafredri mafredri force-pushed the mafredri/feat-devcontainer-install-dotfiles branch from 5b06170 to 1027a37 Compare June 26, 2025 12:19
@mafredri mafredri marked this pull request as ready for review June 26, 2025 12:19
johnstcn
johnstcn approved these changes Jun 26, 2025
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this does sort of highlight the remaining dependencies on the parent workspace. I figure we'd need to have some way for the agent to automatically set these up.

@mafredri
Copy link
Member Author

I guess this does sort of highlight the remaining dependencies on the parent workspace. I figure we'd need to have some way for the agent to automatically set these up.

Yes! This can definitely be improved. It'd be nice to set CODER_DOTFILES_URL as a containerEnv, and if present, run coder dotfiles in the sub agent (startup script?), for example.

@mafredri mafredri enabled auto-merge (squash) June 26, 2025 12:43
@mafredri mafredri merged commit 872aef3 into main Jun 26, 2025
34 checks passed
@mafredri mafredri deleted the mafredri/feat-devcontainer-install-dotfiles branch June 26, 2025 12:50
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@DanielleMaywood DanielleMaywood DanielleMaywood approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mafredri @johnstcn @DanielleMaywood