fix(agent/agentcontainers): prevent reassigning proc.agent until successful #18609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a147216 to
20d2cf1
Compare
20d2cf1 to
77a3d19
Compare
mafredri
commented
Jun 26, 2025
| if err != nil { | ||
| return agent, err | ||
| return SubAgent{}, err |
There was a problem hiding this comment.
Review: In either this or above, we could have returned a semi-valid agent and assigned to proc.agent was is not ideal.
| defer func() { | ||
| if err != nil { | ||
| // Best effort. | ||
| _, _ = a.api.DeleteSubAgent(ctx, &agentproto.DeleteSubAgentRequest{ |
There was a problem hiding this comment.
The steps below should never fail, but if they do, we try to clean up.
DanielleMaywood
approved these changes
Jun 26, 2025
johnstcn
approved these changes
Jun 26, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change applies a bit more defensive coding to the SubAgentClient. I don't have any concrete evidence of this going wrong other than some random observations of "duplicate agent", which are likely unrelated but prompted me to explore.