Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: add user roles to menu #1862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 27, 2022
Merged

Conversation

Kira-Pilot
Copy link
Member

Resolves #1524
Screen Shot 2022-05-27 at 2 33 54 PM

Should I be doing something with organization here? I was a bit confused by the comments in the ticket.

@Kira-Pilot Kira-Pilot requested a review from a team as a code owner May 27, 2022 18:38
@kylecarbs
Copy link
Member

This is a very pretty purple! 😍

@greyscaled greyscaled changed the title chore: add user roles to menu feat: add user roles to menu May 27, 2022
@greyscaled
Copy link
Contributor

greyscaled commented May 27, 2022

Heads up - I changed the PR title to feat:. When you go to squash/merge, can you ensure that it says feat:!

I certainly wouldn't want this feature being deemed a chore!


The comment here explains chore a bit:

# Any code task that operates outside of CI, docs, or the product. Examples
# include configurations, linters etc.
- chore

But the simple way to think of it is:

  • does it change the product or is it visible at all to the user or system?
  • if yes, it's 100% not a chore
  • if no, it might be a chore, or refactor, or test or so on so forth

:D

Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@Kira-Pilot Kira-Pilot merged commit 6052607 into main May 27, 2022
@Kira-Pilot Kira-Pilot deleted the add-user-roles-to-menu/kira-pilot branch May 27, 2022 19:27
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
* view user roles in menu

resolves #1524

* fix stories

* PR feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View User Role(s) in User Menu
3 participants