Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: optimize GetPrebuiltWorkspaces query #18717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 9, 2025
Merged

chore: optimize GetPrebuiltWorkspaces query #18717

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
2c48c95
chore: add test to ensure correct functionality of GetRunningPrebuilt…
johnstcn Jul 2, 2025
68a4304
chore: add test antagonists to enterprise/prebuild/reconcile tests
johnstcn Jul 2, 2025
c95b6d0
chore: alternate optimization for GetRunningPrebuiltWorkspaces
johnstcn Jul 2, 2025
6b4d6dc
chore: get latest preset id
johnstcn Jul 2, 2025
53c3ba5
run both queries and diff results
johnstcn Jul 3, 2025
b237251
fixup! run both queries and diff results
johnstcn Jul 3, 2025
5dc69d9
fixup! run both queries and diff results
johnstcn Jul 3, 2025
5158046
fixup! run both queries and diff results
johnstcn Jul 3, 2025
3e69a1b
fixup! run both queries and diff results
johnstcn Jul 3, 2025
2e760c7
address copilot comments
johnstcn Jul 3, 2025
a0f4f36
use sink instead of spy
johnstcn Jul 7, 2025
30c86cc
add comments to new query CTEs
johnstcn Jul 8, 2025
1d6b4c0
improve querier test
johnstcn Jul 8, 2025
6a1c635
add TODO
johnstcn Jul 8, 2025
e43b5ba
Merge remote-tracking branch 'origin/main' into cj/chore/GetRunningPr…
johnstcn Jul 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add TODO
  • Loading branch information
@johnstcn
johnstcn committed Jul 8, 2025
commit 6a1c635de218108d71d7a3cf254932f622bb519d
1 change: 1 addition & 0 deletions enterprise/coderd/prebuilds/reconcile.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -937,6 +937,7 @@ func SetPrebuildsReconciliationPaused(ctx context.Context, db database.Store, pa
// CompareGetRunningPrebuiltWorkspacesResults compares the original and optimized
// query results and logs any differences found. This function can be easily
// removed once we're confident the optimized query works correctly.
// TODO(Cian): Remove this function once the optimized query is stable and correct.
func CompareGetRunningPrebuiltWorkspacesResults(
ctx context.Context,
logger slog.Logger,
Expand Down
Loading