Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: rename SettingsPages directory to UserSettingsPage #1877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 31, 2022
Merged

refactor: rename SettingsPages directory to UserSettingsPage #1877

merged 1 commit into from
May 31, 2022

Conversation

AbhineetJain
Copy link
Contributor

This PR renames the directory SettingsPages to UserSettingsPage.

Subtasks

  • update the directory name
  • update the import statements

Fixes #1694

@AbhineetJain AbhineetJain requested a review from a team as a code owner May 27, 2022 21:57
@AbhineetJain AbhineetJain changed the title rename settings pages directory rename SettingsPages directory to UserSettingsPage May 27, 2022
@AbhineetJain AbhineetJain force-pushed the abhineetjain/rename-settings-pages-directory branch from d679362 to b1a0380 Compare May 27, 2022 22:23
@AbhineetJain AbhineetJain changed the title rename SettingsPages directory to UserSettingsPage refactor: rename SettingsPages directory to UserSettingsPage May 27, 2022
Kira-Pilot
Kira-Pilot approved these changes May 27, 2022
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!!!!

@AbhineetJain AbhineetJain force-pushed the abhineetjain/rename-settings-pages-directory branch from b1a0380 to f095622 Compare May 28, 2022 09:57
@AbhineetJain AbhineetJain force-pushed the abhineetjain/rename-settings-pages-directory branch from f095622 to e901e92 Compare May 31, 2022 14:08
@AbhineetJain AbhineetJain enabled auto-merge (squash) May 31, 2022 14:08
@AbhineetJain AbhineetJain merged commit 9b19dc9 into main May 31, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/rename-settings-pages-directory branch May 31, 2022 14:16
kylecarbs pushed a commit that referenced this pull request Jun 10, 2022
@AbhineetJain @kylecarbs
refactor: rename SettingsPages directory to UserSettingsPage (#1877)
e326cc8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@greyscaled greyscaled greyscaled approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Confusing page/directory names
4 participants
@AbhineetJain @kylecarbs @greyscaled @Kira-Pilot