-
Notifications
You must be signed in to change notification settings - Fork 881
example: added hetzner cloud workspace #1884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Note: For some reason |
@kylecarbs any idea why the agent is showing up for the non-server resources?
|
Hmm, I'll check this out. I think the DAG needs adjustment to use the closest node, and not work its way entirely up the tree. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks for your contribution @ntimo!
6a2c192
to
49ff3a3
Compare
49ff3a3
to
be89a0e
Compare
I just tested this again with coder version 0.6.5 and coder detects the wrong terraform resource as the server (the firewall attachment resource is detected) @kylecarbs @bpmct |
@ntimo this is certainly a bug on our end. I'll pull the template and try it out. |
@ntimo found the bug! Pushing a fix in ~1hr |
Thanks @kylecarbs you are awesome |
bf9af6e
to
dd57b0e
Compare
I just added the option to chose if code-server should be installed or not when creating the workspace. This is done by using if statements inside of the cloud init file and a counter to add the coder_app resource if needed. |
I will still need to "workarround" a "issue" where hetzner is going to send the admin an email for every server that gets created. Because the server has no ssh key. |
This cleans up agent association code to explicitly map a single agent to a single resource. This will fix #1884, and unblock a prospect from beginning a POC.
714bb9c
to
db360b6
Compare
This cleans up agent association code to explicitly map a single agent to a single resource. This will fix #1884, and unblock a prospect from beginning a POC.
This cleans up agent association code to explicitly map a single agent to a single resource. This will fix #1884, and unblock a prospect from beginning a POC.
This cleans up agent association code to explicitly map a single agent to a single resource. This will fix #1884, and unblock a prospect from beginning a POC.
This cleans up agent association code to explicitly map a single agent to a single resource. This will fix #1884, and unblock a prospect from beginning a POC.
This cleans up agent association code to explicitly map a single agent to a single resource. This will fix #1884, and unblock a prospect from beginning a POC.
I think this one got closed by accident, reopening. |
This cleans up agent association code to explicitly map a single agent to a single resource. This will fix #1884, and unblock a prospect from beginning a POC.
@kylecarbs looks good thank you :) |
I guess this is ready for merge @mafredri :) What do you think? |
Great work on this template @ntimo, love that you even included code-server! We've decided to showcase community templates by linking to them in the examples readme. Would you mind turning this PR into a personal repo that we can link to? I'll make a PR today for adding a community templates section. |
@mafredri sure. There you go https://github.com/ntimo/coder-hetzner-cloud-template |
This PR adds an example for Hetzner Cloud.
The general idea is to let the user create a cloud instance and mount a persistent volume to it. And when the workspace is stopped to unmount the volume and delete the instance to save costs (only the volume will be paid during the stopped time).
In summary this template does:
Note: I had to create a new PR because the fork relation of my fork from #1044 broke.