chore: fix presetParameterAsWorkspaceBuildParameters function

coder · ssncferreira · Jul 28, 2025 · Jul 17, 2025 · Jul 23, 2025 · Jul 23, 2025
commit ae16155a0dacea13f203619009056b5caa2c1454
diff --git a/cli/create.go b/cli/create.go
@@ -297,10 +297,7 @@ func (r *RootCmd) create() *serpent.Command {
 				}
 
 				// Convert preset parameters into workspace build parameters.
-				presetBuildParameters, err := presetParameterAsWorkspaceBuildParameters(preset.Parameters)
-				if err != nil {
-					return xerrors.Errorf("failed to parse preset parameters: %w", err)
-				}
+				presetBuildParameters := presetParameterAsWorkspaceBuildParameters(preset.Parameters)
 				presetParameters = append(presetParameters, presetBuildParameters...)
 
 				// Inform the user which preset was applied and its parameters.

diff --git a/cli/parameter.go b/cli/parameter.go
@@ -100,12 +100,12 @@ func (wpf *workspaceParameterFlags) alwaysPrompt() serpent.Option {
 	}
 }
 
-func presetParameterAsWorkspaceBuildParameters(presetParameters []codersdk.PresetParameter) ([]codersdk.WorkspaceBuildParameter, error) {
+func presetParameterAsWorkspaceBuildParameters(presetParameters []codersdk.PresetParameter) []codersdk.WorkspaceBuildParameter {
 	var params []codersdk.WorkspaceBuildParameter
 	for _, parameter := range presetParameters {
 		params = append(params, codersdk.WorkspaceBuildParameter(parameter))
 	}
-	return params, nil
+	return params
 }
 
 func asWorkspaceBuildParameters(nameValuePairs []string) ([]codersdk.WorkspaceBuildParameter, error) {