fix: only run project discovery when agentDirectory is not empty

We make sure to only run project discovery when the agent directory is not empty. If we attempt to do project discovery when the agent directory is empty we will just get an error.
coder · DanielleMaywood · Jul 22, 2025 · Jul 16, 2025 · Jul 21, 2025 · Jul 21, 2025
commit 2f132148a2ca4e910955dd08702f627f666e2bad
diff --git a/agent/agentcontainers/api.go b/agent/agentcontainers/api.go
@@ -398,7 +398,7 @@ func (api *API) Start() {
 		return
 	}
 
-	if api.projectDiscovery {
+	if api.projectDiscovery && api.agentDirectory != "" {
 		api.discoverDone = make(chan struct{})
 
 		go api.discover()

diff --git a/agent/agentcontainers/api_test.go b/agent/agentcontainers/api_test.go
@@ -3425,4 +3425,29 @@ func TestDevcontainerDiscovery(t *testing.T) {
 			require.Equal(t, tt.expected, got.Devcontainers)
 		})
 	}
+
+	t.Run("NoErrorWhenAgentDirAbsent", func(t *testing.T) {
+		t.Parallel()
+
+		logger := testutil.Logger(t)
+
+		// Given: We have an empty agent directory
+		agentDir := ""
+
+		api := agentcontainers.NewAPI(logger,
+			agentcontainers.WithWatcher(watcher.NewNoop()),
+			agentcontainers.WithManifestInfo("owner", "workspace", "parent-agent", agentDir),
+			agentcontainers.WithContainerCLI(&fakeContainerCLI{}),
+			agentcontainers.WithDevcontainerCLI(&fakeDevcontainerCLI{}),
+			agentcontainers.WithProjectDiscovery(true),
+		)
+
+		// When: We start and close the API
+		api.Start()
+		api.Close()
+
+		// Then: We expect there to have been no errors.
+		// This is implicitly handled by `testutil.Logger` failing when it
+		// detects an error has been logged.
+	})
 }