Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: fix e2e tests #19076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 29, 2025
Merged

fix: fix e2e tests #19076

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0a5dadd
fix: e2e test fixes
jaaydenh Jul 29, 2025
a358a87
fix: fix format
jaaydenh Jul 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: fix format
  • Loading branch information
@jaaydenh
jaaydenh committed Jul 29, 2025
commit a358a87a934f9100a81177b97c3c4ada4a524c09
29 changes: 16 additions & 13 deletions site/e2e/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -903,23 +903,28 @@ const fillParameters = async (
}

// Use modern locator approach instead of waitForSelector
const parameterLabel = page.getByTestId(`parameter-field-${richParameter.name}`);
const parameterLabel = page.getByTestId(
`parameter-field-${richParameter.name}`,
);
await expect(parameterLabel).toBeVisible();

if (richParameter.type === "bool") {
const parameterField = parameterLabel.getByTestId('parameter-field-bool')
const parameterField = parameterLabel
.getByTestId("parameter-field-bool")
.locator(`.MuiRadio-root input[value='${buildParameter.value}']`);
await parameterField.click();
} else if (richParameter.options.length > 0) {
const parameterField = parameterLabel.getByTestId('parameter-field-options')
const parameterField = parameterLabel
.getByTestId("parameter-field-options")
.locator(`.MuiRadio-root input[value='${buildParameter.value}']`);
await parameterField.click();
} else if (richParameter.type === "list(string)") {
throw new Error("not implemented yet"); // FIXME
} else {
// text or number
const parameterField = parameterLabel.getByTestId('parameter-field-text')
.locator('input');
const parameterField = parameterLabel
.getByTestId("parameter-field-text")
.locator("input");
await parameterField.fill(buildParameter.value);
}
}
Expand Down Expand Up @@ -1238,14 +1243,12 @@ export const disableDynamicParameters = async (

// Wait for the success message or page to update
await page
.locator(
"[role='alert']:has-text('Template updated successfully')",
)
.first()
.waitFor({
state: "visible",
timeout: 15000,
});
.locator("[role='alert']:has-text('Template updated successfully')")
.first()
.waitFor({
state: "visible",
timeout: 15000,
});

// Additional wait to ensure the changes are persisted
await page.waitForTimeout(500);
Expand Down
Loading