feat: Update UI for error dialog and snackbar #1971
Conversation
|
Can we make these buttons have the same height than the form buttons? |
|
Also, adding some extra padding in the wrapper to looks closer to the Figma file. |
Sure, let me do that. |
I realized I'll need changes in multiple places to update the other dialogs as well. Let me try those changes. |
|
@BrunoQuaresma I updated the extra padding for |
b11e716 to
0d5e026
Compare
There was a problem hiding this comment.
Certainly looks like an improvement to me! @BrunoQuaresma's been doing a lot of re-design work lately (and is a fantastic designer 🎨), I'm delegating review towards him.
Nice job y'all!
|
Wow! Looking way better. I'll also defer to Bruno, but nice job! |
There was a problem hiding this comment.
LGTM! I think we should make the same for the Confirmation dialog and success alert as well but using the green color. @AbhineetJain what do you think? We probably can do it in another ticket or diff PR. Good job!
|
@BrunoQuaresma Sounds good, thank you! I'll create an issue for that, let's discuss it more there. Edit: #1984 |
* feat: update ui for error dialog and snackbar * update padding for buttons
This PR updates the alarmingly red UI for error dialog and snackbars.
Subtasks
Fixes #1832
Screenshot