-
Notifications
You must be signed in to change notification settings - Fork 881
feat: Workspaces filtering #1972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add all product copy into a Language
object (example the words "Your workspaces" and "All workspaces" in the WorkspacePage
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done @f0ssel . All code comments are really nit, this is fantastic.
Yay for the (scalable) backend implementation. What should be/is the behavior if no term is provided? For example, if I just searched "ammario" and not "owner:ammario" what should happen? |
Right now that's not implemented so it's just ignored. I want to make plain strings (no |
I think that's right @f0ssel. The interesting thing is the search could be against the fully qualified workspace name, so you technically use that to search for owner as well. |
@ammario I added this suggestion, why don't you take a look at this logic and let me know if you would expect different behavior: https://github.com/coder/coder/pull/1972/files#diff-46ce05d14402854a3999da903dcf3949351172316989f053196857f93fcc6d57R198-R229 |
That was a fun exercise of some of my older neurons. That LGTM! I'm excited to see this in action. |
Co-authored-by: G r e y <[email protected]>
e47b601
to
2912d03
Compare
Co-authored-by: G r e y <[email protected]>
I like the UX. The flicker is a bit jank, but I know you realize that too. |
After some awesome styling work from @Kira-Pilot I think this is ready to merge, will be tagging for final reviews. |
great job braving the FE! |
Co-authored-by: G r e y <[email protected]> Co-authored-by: Kira Pilot <[email protected]>
Okay third time is the charm. This one I'd actually like to get merged.
Discussion at #1820
This PR adds a workspace filter to the workspaces page. It uses the backend and it defaults to the workspaces you own, and there's buttons to see all workspaces and a filter bar. Right now the filter bar only functions with the
owner:
query filter.Next steps: