feat: add sharing remove command to the CLI
#19767
Conversation
212d763 to
aa2c2be
Compare
aa2c2be to
a4cd678
Compare
cli/sharing_test.go
Outdated
| ) | ||
| clitest.SetupConfig(t, workspaceOwnerClient, root) | ||
|
|
||
| out := bytes.NewBuffer(nil) |
There was a problem hiding this comment.
nit:
| out := bytes.NewBuffer(nil) | |
| out := new(bytes.Buffer) |
There was a problem hiding this comment.
Resolved in this commit
coderd/workspaces.go
Outdated
| // `GetGroups` returns all groups in the org if `GroupIds` is empty so we check | ||
| // the length before making the DB call. |
There was a problem hiding this comment.
oops! good catch!
are you sure it's just all groups in the org tho? how would it know which org? looking at the query it seems like it would just return every group regardless of org.
| // `GetGroups` returns all groups in the org if `GroupIds` is empty so we check | |
| // the length before making the DB call. | |
| // `GetGroups` returns all groups if `GroupIds` is empty so we check the length first. |
There was a problem hiding this comment.
Resolved in this commit
cli/sharing.go
Outdated
| org, err := orgContext.Selected(inv, client) | ||
| if err != nil { | ||
| return err | ||
| } |
There was a problem hiding this comment.
I don't think we should take --org as a flag. we can already uniquely identify the organization just from the codersdk.Workspace which has OrganizationID and OrganizationName fields. this just makes it likely that someone will accidentally pass in the wrong org and cause problems. from looking through this file it seems like those are the only two org values that get used anyway, so it also saves us a network round trip!
same for the share/add command.
There was a problem hiding this comment.
Good point! I didn't realize that the workspaces had that information already
There was a problem hiding this comment.
Resolved in this commit
Closes coder/internal#861