Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: enforce template-level constraints for TTL and autostart #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jun 7, 2022
Merged

feat: enforce template-level constraints for TTL and autostart #2018

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
1713431
RED: add failing unit tests
johnstcn Jun 2, 2022
f11f942
RED: add migrations and make gen
johnstcn Jun 2, 2022
c5c9a7a
ORANGE: fix audit/diff tests
johnstcn Jun 2, 2022
74f4dee
fixup! RED: add migrations and make gen
johnstcn Jun 2, 2022
7da27a0
fixup! RED: add migrations and make gen
johnstcn Jun 2, 2022
5ad048b
feat: schedule: add schedule.Min function to determine minimum interval
johnstcn Jun 2, 2022
65b980e
ORANGE: coderd: fix a whole bunch of tests
johnstcn Jun 2, 2022
aa298a6
RED: fast-fail some slow-failing tests
johnstcn Jun 2, 2022
a5ec9bf
GREEN: fix even more tests
johnstcn Jun 3, 2022
a6255d6
GREEN: fix final unit test
johnstcn Jun 3, 2022
245795e
cli: templatecreate: add CLI flags --max-ttl --min-autostart-interval
johnstcn Jun 3, 2022
709db5b
fixup! cli: templatecreate: add CLI flags --max-ttl --min-autostart-i…
johnstcn Jun 3, 2022
c4a0927
make gen
johnstcn Jun 3, 2022
244e479
update test entities
johnstcn Jun 3, 2022
60ef479
Merge remote-tracking branch 'origin/main' into 1433-template-constra…
johnstcn Jun 7, 2022
c9aab8b
fixup! Merge remote-tracking branch 'origin/main' into 1433-template-…
johnstcn Jun 7, 2022
f997af2
coderd: default newly-minted workspaces to template max_ttl
johnstcn Jun 7, 2022
d7f697b
address PR comment
johnstcn Jun 7, 2022
ebe4c15
fix broken unit test
johnstcn Jun 7, 2022
08ef2eb
fix some more tests
johnstcn Jun 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make gen
  • Loading branch information
@johnstcn
johnstcn committed Jun 3, 2022
commit c4a09270b4d781142ed04bd20af386afe7623b74
6 changes: 4 additions & 2 deletions site/src/api/typesGenerated.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,6 +245,8 @@ export interface Template {
readonly active_version_id: string
readonly workspace_owner_count: number
readonly description: string
readonly max_ttl_ms: number
readonly min_autostart_interval_ms: number
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question(for FE): Could I use these to set min/max and validations on the WorkspaceScheduleForm ?

I think I can pass the template down into those components and add that logic. Is there any concerns or gotchas or notes about me doing that @johnstcn ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a good idea!

}

// From codersdk/templateversions.go:14:6
Expand Down Expand Up @@ -274,12 +276,12 @@ export interface TemplateVersionParameter {
readonly default_source_value: boolean
}

// From codersdk/templates.go:73:6
// From codersdk/templates.go:75:6
export interface TemplateVersionsByTemplateRequest extends Pagination {
readonly template_id: string
}

// From codersdk/templates.go:27:6
// From codersdk/templates.go:29:6
export interface UpdateActiveTemplateVersion {
readonly id: string
}
Expand Down