fix: Apply environment variables to startup script #2099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was stopping `coder` from being in the path, and allowed applications started in the script to bypass injected environmnet variables like `GIT_SSH_COMMAND`.
f0ssel
approved these changes
Jun 6, 2022
Contributor
f0ssel
left a comment
There was a problem hiding this comment.
Sick, I'm glad it wasn't a more serious architectural issue!
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This was stopping `coder` from being in the path, and allowed applications started in the script to bypass injected environmnet variables like `GIT_SSH_COMMAND`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was stopping
coderfrom being in the path, and allowedapplications started in the script to bypass injected environment
variables like
GIT_SSH_COMMAND.