chore: Update docs manifest home page and icons #2133
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrunoQuaresma
commented
Jun 7, 2022
|
@kylecarbs good catch. cc.: @bpmct @jsjoeio we need to move the README to the docs to make it available on the docs website. Maybe what we can do is replicate the READMEs? Thoughts? |
bpmct
reviewed
Jun 7, 2022
bpmct
approved these changes
Jun 7, 2022
khorne3
approved these changes
Jun 7, 2022
|
Should we make a separate README for the docs? I feel like they shouldn't necessarily be the same, since the routing might be a bit different. |
|
Agreed - I think the docs can have a separate readme. happy to help with this tomorrow. for now, we can just do the table of contents? |
jsjoeio
reviewed
Jun 9, 2022
| { | ||
| "title": "Quickstart", | ||
| "description": "Create your first template and workspace", | ||
| "icon": "<svg class=\"MuiSvgIcon-root jss172\" focusable=\"false\" viewBox=\"0 0 24 24\" aria-hidden=\"true\"><path d=\"M22.7 19l-9.1-9.1c.9-2.3.4-5-1.5-6.9-2-2-5-2.4-7.4-1.3L9 6 6 9 1.6 4.7C.4 7.1.9 10.1 2.9 12.1c1.9 1.9 4.6 2.4 6.9 1.5l9.1 9.1c.4.4 1 .4 1.4 0l2.3-2.3c.5-.4.5-1.1.1-1.4z\"></path></svg>", |
There was a problem hiding this comment.
@BrunoQuaresma I didn't know what icon to use so I just copied another one. We can update before we make the site live
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
* chore: Update docs manifest home page and icons * RRemove contributors * Update template icon * fixup: manifest.json changes * fix: add missing readme to root * fix: add readme to /docs with toc * fix: add quickstart to manifest Co-authored-by: Joe Previte <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.