Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(scripts/metricsdocgen): add promauto.With() pattern to metrics scanner - #21463

Merged
ssncferreira merged 2 commits into
mainfrom
ssncferreira/metricsdocgen-ast-scanner-promauto
Feb 13, 2026
Merged

feat(scripts/metricsdocgen): add promauto.With() pattern to metrics scanner#21463
ssncferreira merged 2 commits into
mainfrom
ssncferreira/metricsdocgen-ast-scanner-promauto

Conversation

@ssncferreira

@ssncferreira ssncferreira commented Jan 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

This PR implements extraction of metrics defined using promauto.With() factory patterns.

Changes

  • Add extractPromautoMetric() to handle:
    • promauto.With(reg).NewCounterVec(prometheus.CounterOpts{...}, labels)
    • factory.NewGaugeVec(prometheus.GaugeOpts{...}, labels)
  • Script generates an updated scripts/metricsdocgen/generated_metrics file

Related to: #13223

Disclosure: This PR was mainly developed with Claude Sonnet 4, with iterative review and refinement by @ssncferreira

This was referenced Jan 8, 2026
Merged
Merged
@ssncferreira Graphite App

ssncferreira commented Jan 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Jan 8, 2026
Merged
Merged
Merged
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from ee2942e to b0e8dc4 Compare January 8, 2026 21:22
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from 109a46e to 403a3c5 Compare January 8, 2026 21:22
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from b0e8dc4 to c4b0acc Compare January 9, 2026 08:51
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch 2 times, most recently from 65a7c50 to c64eacf Compare January 9, 2026 08:52
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from c4b0acc to 0243d78 Compare January 9, 2026 08:52
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from c64eacf to debcf77 Compare January 9, 2026 09:29
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from 0243d78 to 11d9828 Compare January 9, 2026 09:29
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from debcf77 to dac0195 Compare January 9, 2026 09:42
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch 2 times, most recently from 602f312 to ca16038 Compare January 9, 2026 09:47
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch 2 times, most recently from b53a4eb to 556e481 Compare January 9, 2026 10:04
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from ca16038 to 8bc9baa Compare January 9, 2026 10:37
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from 556e481 to 7f37f96 Compare January 9, 2026 10:37
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from 8bc9baa to 7c7892d Compare January 9, 2026 10:38
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from 7f37f96 to 519ac0a Compare January 9, 2026 10:38
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from 7c7892d to 8fc6317 Compare January 9, 2026 10:39
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch 2 times, most recently from f251035 to da49da0 Compare January 9, 2026 10:40
@ssncferreira ssncferreira changed the title feat(scripts): add promauto.With() pattern to metrics scanner feat(scripts/metricsdocgen): add promauto.With() pattern to metrics scanner Jan 9, 2026
@ssncferreira
ssncferreira marked this pull request as ready for review January 9, 2026 11:32
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from a94b964 to cd66231 Compare February 12, 2026 15:57
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch 2 times, most recently from 73c9730 to aff890a Compare February 12, 2026 16:52
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from cd66231 to 13618b3 Compare February 12, 2026 16:52
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from aff890a to 7930e63 Compare February 12, 2026 16:58
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from 13618b3 to 143e11f Compare February 12, 2026 16:58
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from 7930e63 to 54a6a80 Compare February 12, 2026 17:22
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch 2 times, most recently from 2463ea5 to 89e829c Compare February 12, 2026 17:23
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from 54a6a80 to 23d403e Compare February 12, 2026 17:23
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from 89e829c to 1b7cbe5 Compare February 12, 2026 17:54
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from 23d403e to 10d83e9 Compare February 12, 2026 17:54
@coderagents

coderagents Bot commented Feb 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Documentation Check

Updates Needed

This PR improves the metrics scanner to detect promauto.With() patterns, which discovered 37 new metrics (21 not yet in user-facing documentation). However, the automatic merging of generated_metrics into docs requires PR #21464 to be merged first.

Dependency: This PR depends on #21464 which adds the merging functionality.

Metrics still missing from docs (click to expand)

These metrics are now in generated_metrics but won't appear in docs until #21464 merges:

  • coderd_authz_authorize_duration_seconds
  • coderd_authz_prepare_authorize_duration_seconds
  • coderd_lifecycle_autobuild_execution_duration_seconds
  • coderd_notifications_dispatch_attempts_total
  • coderd_notifications_dispatcher_send_seconds
  • coderd_notifications_inflight_dispatches
  • coderd_notifications_pending_updates
  • coderd_notifications_queued_seconds
  • coderd_notifications_retry_count
  • coderd_notifications_synced_updates_total
  • coderd_open_file_refs_current
  • coderd_open_file_refs_total
  • coderd_open_files_current
  • coderd_open_files_size_bytes_current
  • coderd_open_files_size_bytes_total
  • coderd_open_files_total
  • coderd_prebuilds_reconciliation_duration_seconds
  • connect_sessions_total
  • inflight_mitm_requests
  • mitm_requests_total
  • mitm_responses_total

Note: Some metrics (API, OAuth2, provisioner, workspace) are already documented because they were previously in the static metrics file.

Automated review via Coder Tasks

@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from 10d83e9 to 0c10e4e Compare February 12, 2026 18:33
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch from 14771de to 5f74a61 Compare February 12, 2026 18:41
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch 2 times, most recently from d9d6977 to ca4d6a7 Compare February 12, 2026 18:43
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-opts branch 2 times, most recently from c110fa1 to 9832bc8 Compare February 13, 2026 10:20
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from b35a400 to c7d424c Compare February 13, 2026 10:20
@ssncferreira Graphite App

ssncferreira commented Feb 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Merge activity

  • Feb 13, 10:48 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Feb 13, 11:15 AM UTC: Graphite rebased this pull request as part of a merge.
  • Feb 13, 11:24 AM UTC: @ssncferreira merged this pull request with Graphite.

@ssncferreira
ssncferreira changed the base branch from ssncferreira/metricsdocgen-ast-scanner-opts to graphite-base/21463 February 13, 2026 11:02
@ssncferreira
ssncferreira changed the base branch from graphite-base/21463 to main February 13, 2026 11:14
@ssncferreira
ssncferreira force-pushed the ssncferreira/metricsdocgen-ast-scanner-promauto branch from c7d424c to 3a022d4 Compare February 13, 2026 11:14
@ssncferreira
ssncferreira merged commit 55d1a32 into main Feb 13, 2026
33 checks passed
@ssncferreira
ssncferreira deleted the ssncferreira/metricsdocgen-ast-scanner-promauto branch February 13, 2026 11:24
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@ssncferreira ssncferreira

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ssncferreira @mtojek