feat: set $HOME for coder agent in aws-linux template #2150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <[email protected]>
mafredri
approved these changes
Jun 8, 2022
Member
mafredri
left a comment
There was a problem hiding this comment.
still left is Digital Ocean.
I don't think it will be needed there, the agent is started via systemd so the env should be ok.
| #!/bin/bash | ||
| sudo -E -u ubuntu sh -c '${coder_agent.dev.init_script}' | ||
| sudo -u ubuntu sh -c '${coder_agent.dev.init_script}' |
Member
There was a problem hiding this comment.
We could consider using -H to ensure HOME is set.
Contributor
Author
There was a problem hiding this comment.
man page says that -H might be a system default, and in ubuntu is seems to be the case. Feels like overkill
kylecarbs
pushed a commit
that referenced
this pull request
Jun 10, 2022
Signed-off-by: Spike Curtis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second PR for #1386 --- still left is Digital Ocean.
It's unclear to me why we used
-Ein the first place; it doesn't make sense to me to pass the environment vars from the startup script (presumably running as root) to the agent script. Perhaps just mistakenly thinking we needed variables from provisioner/terraform to get passed---but these get substituted by terraform before the script is set in the metadata.