fix: add modal to <DropdownMenu /> - #22061
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3a898f9a8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
is it intended that we lost the "active" part? 
|
|
PromptSelectTrigger.tsx and PromptSelectTrigger.stories.tsx are no longer used. Should these be removed? |
…r/coder into jakehwll/modal-dropdownmenu
|
@jakehwll I pushed a commit that with a css change that should resolve the scrollbar layout shift issue without changing modal behavior on the dropdownmenu. If this looks good to you, lets remove all the dropdownmenu changes. |
This pull-request ensures that our
<DropdownMenu />elements don't cause a layout shift with the scrollbars, this does now cause the scroll to not lock at all when we open a<DropdownMenu />however.It should be noted this will not effect
<Select />'s as their underlying code does not allow formodal={true}. This was noticed primarily on the/taskspage so their components have been migrated to a<DropdownMenu />.