feat: implement new default monospace font Geist Mono#22081
Open
feat: implement new default monospace font Geist Mono#22081
Geist Mono#22081Conversation
Geist MonoGeist Mono
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ea08781b3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
jaaydenh
reviewed
Mar 3, 2026
| fontFamily: { | ||
| sans: `"Geist Variable", system-ui, sans-serif`, | ||
| // `monospace, monospace` resets the font-size to 16px with the fallback. | ||
| mono: `"Geist Mono Variable", system-ui, monospace, monospace`, |
Contributor
There was a problem hiding this comment.
Im not sure that system-ui makes sense as a fallback for mono spaced fonts
jaaydenh
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request follows up #22060
Felt wrong to only make use of Geist when there is a Monospace variant here too. Felt best we default to this as the default font as its inline with the rest of the application. This also updates the lower line for Workspace Statistics 🙂