fix: Use explicit resource order when assocating agents #2219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d94e224 to
1033852
Compare
This cleans up agent association code to explicitly map a single agent to a single resource. This will fix #1884, and unblock a prospect from beginning a POC.
deansheather
approved these changes
Jun 9, 2022
Comment on lines
+54
to
+55
| var findTerraformResources func(mod *tfjson.StateModule) | ||
| findTerraformResources = func(mod *tfjson.StateModule) { |
There was a problem hiding this comment.
Suggested change
| var findTerraformResources func(mod *tfjson.StateModule) | |
| findTerraformResources = func(mod *tfjson.StateModule) { | |
| findTerraformResources := func(mod *tfjson.StateModule) { |
There was a problem hiding this comment.
Can't do that because it calls itself ;p
kylecarbs
added a commit
that referenced
this pull request
Jun 10, 2022
This cleans up agent association code to explicitly map a single agent to a single resource. This will fix #1884, and unblock a prospect from beginning a POC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up agent association code to explicitly map a single
agent to a single resource. This will fix #1884, and unblock
a prospect from beginning a POC.