Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site): await dialog close after publish to prevent act() warnings #22334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jeremyruppel merged 1 commit into from
Feb 27, 2026
Merged

fix(site): await dialog close after publish to prevent act() warnings #22334

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions site/src/pages/TemplateVersionEditorPage/TemplateVersionEditorPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,14 @@ test("Use custom name, message and set it as active when publishing", async () =
name: "v1.0",
message: "Informative message",
});
expect(updateActiveTemplateVersion).toBeCalledWith("test-template", {
id: "new-version-id",
});
});
expect(updateActiveTemplateVersion).toBeCalledWith("test-template", {
id: "new-version-id",
// Wait for the dialog to close so all async state updates (setIsPublishingDialogOpen,
// setLastSuccessfulPublishedVersion, navigation) settle before the test ends.
await waitFor(() => {
expect(screen.queryByTestId("dialog")).not.toBeInTheDocument();
});
});

Expand Down Expand Up @@ -195,6 +200,11 @@ test("Do not mark as active if promote is not checked", async () => {
});
});
expect(updateActiveTemplateVersion).toBeCalledTimes(0);
// Wait for the dialog to close so all async state updates settle before the
// test ends, preventing act() warnings from pending state mutations.
await waitFor(() => {
expect(screen.queryByTestId("dialog")).not.toBeInTheDocument();
});
});

test("Patch request is not send when there are no changes", async () => {
Expand Down
Loading