Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: break word to wrap long strings in stats, add media query #2310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2022

Conversation

AbhineetJain
Copy link
Contributor

@AbhineetJain AbhineetJain commented Jun 13, 2022

This PR wraps long strings in stats label and value by breaking the word. Also adds a media query to arrange the stats vertically without the divider.

Subtasks

  • add media query for size below 960px to arrange the stats vertically
  • update styles to break long words to wrap them
  • added story for small screen
  • added story for long active version name

Fixes #2300

Screenshots

Small screens (<960px)

Screen Shot 2022-06-13 at 8 10 25 PM

Long names

image

@AbhineetJain AbhineetJain requested a review from a team as a code owner June 13, 2022 23:44
@Kira-Pilot
Copy link
Member

Thanks for looking at this! I think this is a good incremental change. Some things I'd like to see down the road:

  • we consider using flexbox for these stats containers
  • we consolidate the table components so we don't have to update styles in two places
  • we consider a character limit on template and workspace names

@AbhineetJain
Copy link
Contributor Author

Thanks for looking at this! I think this is a good incremental change. Some things I'd like to see down the road:

  • we consider using flexbox for these stats containers
  • we consolidate the table components so we don't have to update styles in two places
  • we consider a character limit on template and workspace names

@Kira-Pilot Those are good suggestions. Should we file an issue to track these?

@AbhineetJain AbhineetJain merged commit 55e538e into main Jun 15, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/2300-text-overflow-template-stats branch June 15, 2022 15:16
@Kira-Pilot
Copy link
Member

@AbhineetJain I wouldn't worry about it right now. I think some of them will be resolved as part of that general flexbox ticket we looked at during grooming.

@AbhineetJain
Copy link
Contributor Author

@Kira-Pilot Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Template stats overflow on smaller screens
2 participants