fix(site): address self-review findings (separator, overflow, story)

coder · DanielleMaywood · Apr 15, 2026 · Apr 13, 2026 · Apr 13, 2026 · Apr 13, 2026
commit 9c4be48ecddada7062f85772d0ec7ca8e84bc7ed
diff --git a/site/src/pages/AgentsPage/components/AgentChatInput.tsx b/site/src/pages/AgentsPage/components/AgentChatInput.tsx
@@ -930,18 +930,18 @@ export const AgentChatInput: FC<AgentChatInputProps> = ({
 						 * hide and reorder via CSS. The pill is invisible
 						 * when there's no overflow but still occupies
 						 * layout space, preventing measurement flicker. */}
+						{workspace && workspaceAgent && chatId && (
+							<WorkspacePill
+								workspace={workspace}
+								agent={workspaceAgent}
+								chatId={chatId}
+								sshCommand={sshCommand}
+							/>
+						)}
 						<div
 							ref={badgeContainerRef}
 							className="flex min-w-0 items-center gap-1 overflow-hidden"
 						>
-							{workspace && workspaceAgent && chatId && (
-								<WorkspacePill
-									workspace={workspace}
-									agent={workspaceAgent}
-									chatId={chatId}
-									sshCommand={sshCommand}
-								/>
-							)}{" "}
 							{allBadges.map((badge, i) => {
 								const isOverflow = overflowCount > 0 && i >= visibleCount;
 								return (

diff --git a/site/src/pages/AgentsPage/components/ChatTopBar.tsx b/site/src/pages/AgentsPage/components/ChatTopBar.tsx
@@ -192,7 +192,6 @@ export const ChatTopBar: FC<ChatTopBarProps> = ({
 						>
 							{!isArchived && (
 								<>
-									<DropdownMenuSeparator />
 									{onRegenerateTitle && (
 										<>
 											<DropdownMenuItem
@@ -204,7 +203,7 @@ export const ChatTopBar: FC<ChatTopBarProps> = ({
 											</DropdownMenuItem>
 											<DropdownMenuSeparator />
 										</>
-									)}
+									)}{" "}
 								</>
 							)}
 							{isArchived ? (

diff --git a/site/src/pages/AgentsPage/components/WorkspacePill.stories.tsx b/site/src/pages/AgentsPage/components/WorkspacePill.stories.tsx
@@ -167,21 +167,13 @@ export const WithExternalAppsOnly: Story = {
 	},
 };
 
-/** When the agent has no apps at all, the pill renders as a simple link
- *  to the workspace page instead of a dropdown trigger. */
+/** When the agent has no apps at all, the component returns null.
+ *  The fallback plain link is handled by the ToolBadge in
+ *  AgentChatInput, not by WorkspacePill. */
 export const NoApps: Story = {
 	args: {
 		...defaultProps,
 		workspace: MockWorkspace,
 		agent: agentWithNoApps,
 	},
-	play: async ({ canvasElement }) => {
-		const canvas = within(canvasElement);
-		const link = canvas.getByText("Test-Workspace");
-		// The pill should be a link, not a dropdown trigger.
-		expect(link.closest("a")).toHaveAttribute(
-			"href",
-			expect.stringContaining("/@"),
-		);
-	},
 };