refactor: Add install script for coder CLI #243
Conversation
Codecov Report
@@ Coverage Diff @@
## main #243 +/- ##
==========================================
- Coverage 67.31% 67.02% -0.30%
==========================================
Files 120 120
Lines 6484 6484
Branches 67 67
==========================================
- Hits 4365 4346 -19
- Misses 1701 1717 +16
- Partials 418 421 +3
Continue to review full report at Codecov.
|
install.sh
Outdated
|
|
||
| go install cmd/coder/main.go | ||
| echo "Coder CLI now installed at:" | ||
| echo "$(which coder)" |
There was a problem hiding this comment.
We can make this more accurate with:
echo "$(go env GOPATH)/bin/coder"
There was a problem hiding this comment.
could even do both, install to that location, check if they are different, and if so, emit a warning indicating that something else in PATH is shadowing the one we just installed
There was a problem hiding this comment.
also, unsure whether it matters for this particular script, but if you run it on Windows, then it might not work correctly due to the .exe extension
There was a problem hiding this comment.
I switched to use make install here: 0b16731 - and made the extension matching in 4415638
Our current strategy (having ./develop.sh and a Makefile) is assuming we have some sort of POSIX toolchain in the Windows environment - like Mingw/cygwin. Might be something we have to think about fixing up later.
Sure! I think the canonical way for Still kind of sounds like it would install everything - but since we're copying all the binaries ( |
|
I think that'd be good! I'm just used to |
This adds an
install.shscript at the root which runsgo install cmd/coder/main.go- makingcoderavailable by default in our workspaces (where thegobin folder is already in thePATH).I thought this might be helpful for developer who aren't familiar with
goor the directory structure, in runningcoderCLI locally. Open to other ideas though!