Add reason field for workspace builds
#2438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
approved these changes
Jun 16, 2022
5 tasks
This was referenced Jun 16, 2022
johnstcn
reviewed
Jun 17, 2022
| Transition: trans, | ||
| JobID: newProvisionerJob.ID, | ||
|
|
||
| err = store.InTx(func(db database.Store) error { |
There was a problem hiding this comment.
This is already in one big transaction, see line 80 -- since we're already in a tx, this ends up being a no-op
There was a problem hiding this comment.
Oh TIL. I didn't see that @AbhineetJain
There was a problem hiding this comment.
Thanks @johnstcn. This was also the reason the tests were failing.
778b819 to
4802eaf
Compare
4802eaf to
c5b9aac
Compare
Kira-Pilot
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
reasonfield for workspace builds to indicate the reason for its initiation. The following values are supported:initiator,autostart,autostop.The following combinations can arise:
In case of
Reason.AutostartandReason.Autostop, we ignore the initiator field when displaying it in the UI, and use the initiator field for the other case - the member could be admin too (or whoever the user may possibly be sharing workspaces with).Subtasks