feat: add provider_item_id to ai-gateway tool usage recording - #24562
Closed
dannykopping wants to merge 5 commits into
Closed
feat: add provider_item_id to ai-gateway tool usage recording#24562dannykopping wants to merge 5 commits into
provider_item_id to ai-gateway tool usage recording#24562dannykopping wants to merge 5 commits into
Conversation
dannykopping
commented
Apr 21, 2026
dannykopping
left a comment
Contributor
Author
There was a problem hiding this comment.
Self-review ✅
| github.com/brianvoe/gofakeit/v7 v7.14.0 | ||
| github.com/coder/agentapi-sdk-go v0.0.0-20250505131810-560d1d88d225 | ||
| github.com/coder/aibridge v1.1.3-0.20260420072253-d474d6813420 | ||
| github.com/coder/aibridge v1.1.3-0.20260421115004-34c9a190da9a |
Contributor
Author
There was a problem hiding this comment.
TODO: replace with merge commit from coder/aibridge#273
dannykopping
marked this pull request as ready for review
April 21, 2026 13:26
provider_item_id to ai-gateway tool usage recording
Adds a separate provider_item_id column to aibridge_tool_usages to capture the output item's unique ID independently from the provider_tool_call_id (which is the correlation ID for agentic tools). This avoids conflating two semantically different identifiers: - provider_item_id: the output item's unique id (always present) - provider_tool_call_id: the call_id used to correlate tool output (empty for hosted tools like web_search_call) Changes: - Migration 000472: adds provider_item_id column - Proto: adds item_id field (field 11) to RecordToolUsageRequest - Server handler: plumbs item_id through to DB insert - Translator: TODO placeholder until aibridge dep is bumped Depends on: coder/aibridge#273
- Bump github.com/coder/aibridge to 34c9a190 which adds ItemID to ToolUsageRecord. - Wire req.ItemID in the translator (replaces TODO placeholder). - Remove Responses API-specific wording from migration comment.
The aibridge code was moved into coder/coder (PR #24190), so the external go.mod dependency is no longer needed. The ItemID field on ToolUsageRecord is added here since it is required by the translator and server handler. Migration renumbered from 000472 to 000475 to avoid conflicts with migrations added since the original PR was created.
dannykopping
force-pushed
the
danny/aigov-96-tool-item-id
branch
from
April 23, 2026 08:54
d5f1b68 to
902891b
Compare
Contributor
Author
What makes you think it's not? |
Contributor
I don't see any changes to |
Contributor
Author
Oh, that kind of tested. Yeah I can add a test to validate that the field is persisted. |
Inserts a tool usage with both ProviderItemID and ProviderToolCallID set, then reads it back via GetAIBridgeToolUsagesByInterceptionID to confirm both fields round-trip through the database.
pawbana
reviewed
Apr 23, 2026
| InitiatorID: user.ID, | ||
| }, nil) | ||
|
|
||
| tool := dbgen.AIBridgeToolUsage(t, db, database.InsertAIBridgeToolUsageParams{ |
Contributor
There was a problem hiding this comment.
I think RecordToolUsage function should be tested that it properly stores the ItemID field.
I don't think checking dbgen.AIBridgeToolUsage is needed.
Contributor
Author
There was a problem hiding this comment.
Fair. I'm juggling too many topics. Let me get to this when I have a chance to spend some brain tokens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer: implemented by a Coder Agent using Claude Opus 4.6
Summary
Adds a separate
provider_item_idcolumn toaibridge_tool_usagesto capture the output item's unique ID independently fromprovider_tool_call_id.This addresses review feedback from coder/aibridge#273 — conflating the item
idandcall_idinto a single field causes data consistency issues when other sources record these fields correctly.Why two IDs?
Provider tool call output items can have two distinct identifiers:
idcall_idHosted tools (
web_search_call,file_search_call,code_interpreter_call,image_generation_call,mcp_call) only haveid— nocall_id— because the server executes them internally.For
/v1/chat/completionsand Anthropic/v1/messages, onlyToolCallIDis populated (it's the correlation ID in both APIs).ItemIDstays empty since those APIs don't have a separate item ID concept.Changes
provider_item_idcolumn toaibridge_tool_usagesitem_idfield (field 11) toRecordToolUsageRequestitem_idthrough to DB insert + structured loggingToolUsageRecord.ItemID→ protoItemIdcoder/aibridgeto34c9a190(addsItemIDfield)Dependencies
Depends on coder/aibridge#273 being merged first (the go.mod points at the branch commit).
Linear: AIGOV-96