Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: stop tracking chat title in audit logs#24564

Merged
johnstcn merged 3 commits into
mainfrom
cian/stop-tracking-chat-title-audit
Apr 21, 2026
Merged

fix: stop tracking chat title in audit logs#24564
johnstcn merged 3 commits into
mainfrom
cian/stop-tracking-chat-title-audit

Conversation

@johnstcn
Copy link
Copy Markdown
Member

Chat titles can contain sensitive information (secrets, internal project names, etc.) and should not be visible in audit logs.

  • Use truncated chat UUID (first 8 chars) as resource_target instead of the title
  • Mark the title field as ActionSecret so diffs render as ••••••••
Implementation notes

Two changes:

  1. coderd/audit/request.go: ResourceTarget for Chat returns typed.ID.String()[:8] instead of typed.Title
  2. enterprise/audit/table.go: Chat title field tracking changed from ActionTrack to ActionSecret

No frontend changes needed. The frontend already handles secret: true fields.

🤖

Copy link
Copy Markdown
Member Author

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self-reviewed

@johnstcn johnstcn marked this pull request as ready for review April 21, 2026 13:16
@johnstcn johnstcn merged commit 4d45b69 into main Apr 21, 2026
31 checks passed
@johnstcn johnstcn deleted the cian/stop-tracking-chat-title-audit branch April 21, 2026 13:26
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants