Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(mise): upgrade helm to 3.21 to fix helm testdata generation - #25520

Merged
dannykopping merged 1 commit into
mainfrom
dk/mise-helm-fix
May 20, 2026
Merged

fix(mise): upgrade helm to 3.21 to fix helm testdata generation#25520
dannykopping merged 1 commit into
mainfrom
dk/mise-helm-fix

Conversation

@dannykopping

Copy link
Copy Markdown
Contributor

With helm=3.12.0, when running make -B helm/coder/tests/testdata/.gen-golden it doesn't respect the namespace override defined in helm/coder/tests/chart_test.go:

// runHelmTemplate runs helm template on the given chart with the given values and
// returns the raw output.
func runHelmTemplate(t testing.TB, helmPath, chartDir, valuesFilePath, namespace string) (string, error) {
	// Ensure that valuesFilePath exists
	if _, err := os.Stat(valuesFilePath); err != nil {
		return "", xerrors.Errorf("values file %q does not exist: %w", valuesFilePath, err)
	}

	cmd := exec.Command(helmPath, "template", chartDir, "-f", valuesFilePath, "--namespace", namespace)
	t.Logf("exec command: %v", cmd.Args)
	out, err := cmd.CombinedOutput()
	return string(out), err
}

This results in:

$ git diff | head
diff --git a/helm/coder/tests/testdata/auto_access_url_1_coder.golden b/helm/coder/tests/testdata/auto_access_url_1_coder.golden
index be09066fb1..a6a064e535 100644
--- a/helm/coder/tests/testdata/auto_access_url_1_coder.golden
+++ b/helm/coder/tests/testdata/auto_access_url_1_coder.golden
@@ -12,14 +12,14 @@ metadata:
     app.kubernetes.io/version: 0.1.0
     helm.sh/chart: coder-0.1.0
   name: coder
-  namespace: coder
+  namespace: default

@dannykopping
dannykopping merged commit fe01efe into main May 20, 2026
26 checks passed
@dannykopping
dannykopping deleted the dk/mise-helm-fix branch May 20, 2026 08:15
@github-actions github-actions Bot locked and limited conversation to collaborators May 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants