Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site): CredentialField: mask api key after submit #25848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
johnstcn merged 5 commits into from
Jun 2, 2026
Merged

fix(site): CredentialField: mask api key after submit #25848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e8f48f9
fix(site/src/pages/AISettingsPage/ProvidersPage): use password input …
johnstcn May 29, 2026
253b738
address R2 findings
johnstcn May 29, 2026
2eaa3de
Merge branch 'main' into cj/ai-settings-api-key-masking
johnstcn May 29, 2026
0bb338f
Merge remote-tracking branch 'origin/main' into cj/ai-settings-api-ke…
johnstcn Jun 2, 2026
c77f259
Merge branch 'main' into cj/ai-settings-api-key-masking
johnstcn Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion site/src/api/queries/aiProviders.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import type {

const aiProvidersListKey = ["ai", "providers"] as const;

const aiProviderKeyFor = (idOrName: string) =>
export const aiProviderKeyFor = (idOrName: string) =>
[...aiProvidersListKey, idOrName] as const;

export const aiProvidersList = () => ({
Expand Down
6 changes: 6 additions & 0 deletions site/src/pages/AISettingsPage/ProvidersPage/UpdateProviderPage/UpdateProviderPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import { toast } from "sonner";
import { getErrorMessage } from "#/api/errors";
import {
aiProvider,
aiProviderKeyFor,
deleteAIProviderMutation,
updateAIProviderMutation,
} from "#/api/queries/aiProviders";
Expand Down Expand Up @@ -171,6 +172,10 @@ const UpdateProviderPageView: React.FC = () => {
{ enabled: checked },
{
onSuccess: (updated) => {
queryClient.setQueryData(
aiProviderKeyFor(providerId),
updated,
);
toast.success(
`Provider "${updated.display_name || updated.name}" ${checked ? "enabled" : "disabled"}.`,
);
Expand Down Expand Up @@ -200,6 +205,7 @@ const UpdateProviderPageView: React.FC = () => {
const request = providerFormValuesToUpdate(values, provider);
try {
const updated = await updateMutation.mutateAsync(request);
queryClient.setQueryData(aiProviderKeyFor(providerId), updated);
toast.success(
`Provider "${updated.display_name || updated.name}" updated.`,
);
Expand Down
8 changes: 7 additions & 1 deletion site/src/pages/AISettingsPage/ProvidersPage/components/CredentialField.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ type CredentialFieldProps = {
placeholder?: string;
description?: React.ReactNode;
required?: boolean;
onBlur?: () => void;
onFocus?: () => void;
};

Expand All @@ -20,6 +21,7 @@ export const CredentialField: React.FC<CredentialFieldProps> = ({
placeholder,
description,
required = false,
onBlur,
onFocus,
}) => {
const inputId = useId();
Expand Down Expand Up @@ -62,9 +64,13 @@ export const CredentialField: React.FC<CredentialFieldProps> = ({
<Input
id={inputId}
name={helpers.name}
className="font-mono text-[13px]"
value={helpers.value}
onChange={helpers.onChange}
onBlur={helpers.onBlur}
onBlur={(event) => {
helpers.onBlur(event);
onBlur?.();
}}
onFocus={onFocus}
autoComplete={autoComplete}
placeholder={placeholder}
Expand Down
Loading
Loading