refactor: extract workspace filter into a separate component #2601
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4250e3 to
d854016
Compare
Kira-Pilot
reviewed
Jun 23, 2022
site/src/components/SearchBarWithFilter/SearchBarWithFilter.stories.tsx
Outdated
Show resolved
Hide resolved
|
I think this is a great cleanup! |
74a7689 to
d6d8b0d
Compare
Kira-Pilot
approved these changes
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a generic search with filter component which can be used across different pages.
Subtasks
SearchBarWithFilterThis component will be used to filter users on the Users list page (#595)