feat: implement package and cli tool for repairing oidc links - #26418
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
When changing oidc providers, all existing links need to be reset.
Emyrk
force-pushed
the
stevenmasley/reset_oidc
branch
from
June 16, 2026 16:27
fc01d2c to
2b0804e
Compare
Emyrk
commented
Jun 16, 2026
Comment on lines
+72
to
+106
| // ResolveIssuer uses OIDC discovery to fetch the canonical issuer string | ||
| // from the provider's .well-known/openid-configuration endpoint. | ||
| // This does not require OIDC client credentials. | ||
| // | ||
| // This works the same as `oidc.NewProvider`. The `oidc` package does not | ||
| // expose a method to extract the Issuer. So we have to manually make the | ||
| // http request. | ||
| func ResolveIssuer(ctx context.Context, cli *http.Client, issuerURL string) (string, error) { | ||
| wellKnownURL := issuerURL + "/.well-known/openid-configuration" | ||
| req, err := http.NewRequestWithContext(ctx, http.MethodGet, wellKnownURL, nil) | ||
| if err != nil { | ||
| return "", xerrors.Errorf("create discovery request: %w", err) | ||
| } | ||
|
|
||
| resp, err := cli.Do(req) | ||
| if err != nil { | ||
| return "", xerrors.Errorf("fetch OIDC discovery document: %w", err) | ||
| } | ||
| defer resp.Body.Close() | ||
|
|
||
| if resp.StatusCode != http.StatusOK { | ||
| return "", xerrors.Errorf("OIDC discovery returned HTTP %d", resp.StatusCode) | ||
| } | ||
|
|
||
| var discovery struct { | ||
| Issuer string `json:"issuer"` | ||
| } | ||
| if err := json.NewDecoder(resp.Body).Decode(&discovery); err != nil { | ||
| return "", xerrors.Errorf("decode OIDC discovery document: %w", err) | ||
| } | ||
| if discovery.Issuer == "" { | ||
| return "", xerrors.New("OIDC discovery document has empty issuer field") | ||
| } | ||
| return discovery.Issuer, nil | ||
| } |
Member
Author
There was a problem hiding this comment.
This is unfortunate, but the oidc package does not export the necessary fields to reuse it. We have to manually make the http request 😢
Contributor
Docs preview📖 View docs preview for |
Emyrk
force-pushed
the
stevenmasley/reset_oidc
branch
from
June 16, 2026 16:56
0fef740 to
c88e154
Compare
Emyrk
marked this pull request as ready for review
June 16, 2026 16:59
Contributor
Documentation CheckUpdates Needed
Automated review via Coder Agents |
Emyrk
force-pushed
the
stevenmasley/reset_oidc
branch
from
June 16, 2026 17:11
c88e154 to
eb1149f
Compare
sreya
approved these changes
Jun 16, 2026
| -- and does not begin with the expected issuer prefix. This allows users to | ||
| -- re-authenticate under a new OIDC provider. | ||
| UPDATE user_links | ||
| SET linked_id = '' |
Collaborator
There was a problem hiding this comment.
is there any benefit to letting these linger? Why not just delete these?
Member
Author
There was a problem hiding this comment.
You mean remove the row entirely?
If we remove the row, we lose their existing OIDC token. Which would break any existing access that token has until the user logs back in.
Our session tokens like a week or so. So new workspaces could be broken until they log out + log in.
Emyrk
force-pushed
the
stevenmasley/reset_oidc
branch
from
June 16, 2026 19:03
eb1149f to
59b3caf
Compare
Emyrk
force-pushed
the
stevenmasley/reset_oidc
branch
from
June 16, 2026 19:28
59b3caf to
58b1963
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can probably drop this cli command once the auto code (stacked on this) is defaulted to
true.